Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ CI Deps #2251

Merged
merged 27 commits into from
Jul 22, 2024
Merged

Fix/ CI Deps #2251

merged 27 commits into from
Jul 22, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Jul 22, 2024

Fixes

This PR fixes several CI issues.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@0xArdi 0xArdi marked this pull request as ready for review July 22, 2024 14:14
@0xArdi 0xArdi changed the title chore: pin protolint on macOS Fix/ CI Deps Jul 22, 2024
Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @0xArdi maybe squash a couple of commits together or all of them on merge?

@0xArdi
Copy link
Collaborator Author

0xArdi commented Jul 22, 2024

@Adamantios lets squash all, theres no point in having any. Its just the nature of the fix, had to do a lot of commits to test.

@Adamantios Adamantios merged commit 197fb43 into doc/dynamic_hello_world_hash Jul 22, 2024
20 of 21 checks passed
@Adamantios Adamantios deleted the fix/ci branch July 22, 2024 14:57
Adamantios pushed a commit that referenced this pull request Jul 22, 2024
fix: CI dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants